vanstyn / RapidApp

Turnkey ajaxy webapps
http://rapi.io
Other
48 stars 15 forks source link

Call ->_setup after reblessing in MetaKeys::Loader->new #159

Closed ilmari closed 8 years ago

ilmari commented 8 years ago

Schema::Loader::DBI->new doesn't rebless when using a custom loader_class, so its call to ->_setup doesn't call the right subclass method.

An upcoming change to Schema::Loader introduces caching of table info by wrapping the relevant methods in ->_setup, which becomes less effective if it's not called on the subclass.

vanstyn commented 8 years ago

Thanks!

vanstyn commented 8 years ago

tested and confirmed this was the root of the problem in https://rt.cpan.org/Ticket/Display.html?id=105279 (which I had opened) and I have now closed out. Thanks again, @ilmari !!