search

vanstyn / RapidApp

Turnkey ajaxy webapps
http://rapi.io
Other
48 stars 15 forks source link

Contain pop-up windows to Tabs instead of whole browser #6

Closed vanstyn closed 9 years ago

vanstyn commented 11 years ago

Currently pop-up windows and dialogs consume the entire browser with a grey overlay. When in the context of the standard TabGui interface, it would be better to isolate the window to the origin tab so that other tabs can be opened and accessed while the window is open.

This would be particularly useful to be able to compare and lookup data while in the middle of an edit within a window, for example.

The user can still always open another browser window, but this would be more convenient

vanstyn commented 9 years ago

After looking into this, this is something that needs to be done on a case-by-case basis rather than in a general/across-the-board manner, simply because there is no safe way to know that a given window is associated with a given tab (just due to the async nature of JavaScript). The good news is that this is already a simple thing to do with Ext.Window; just set renderTo property... But it will have to be done in all places which generate a dialog, which means some cases will be easier than others...

vanstyn commented 9 years ago

With the last commit (4b28d58493) all of the windows that I can think of right now have been configured to be constrained, and since this ended up becoming a case-by-case implementation, I'm closing this issue, considering it resolved. New/other cases with crop up in the future will just be handled independently