[FEATURE] Add Cache instances details

vantage-sh / ec2instances.info

Amazon EC2 instance comparison site

https://ec2instances.info

MIT License

5.19k stars 585 forks source link

[FEATURE] Add Cache instances details #605

Closed V0lantis closed 2 years ago

V0lantis commented 2 years ago

Add cache instance pricing informations to the website. It is a lot similar to the rds scarping approach.

There is still a bug in the ouput website, and I would like some help to get over it before merging :)

brookemckim commented 2 years ago

Hi @V0lantis thanks for this. What bug are you seeing? I can assist with this.

V0lantis commented 2 years ago

As you can see in the screenshot I join with this comment, the table showed are printing some columns that I don't want (EBS THROUGHPUT for example). Also, the filtering and sorting feature are not working. I must admit being a little bit lazy on this part, because I don't know how to easily correct the bug. Could you try to fix it on your side?

Capture d’écran 2022-03-21 à 15 42 54

I have the following error in my console : Capture d’écran 2022-03-21 à 15 45 19 Maybe, this would help you find out where the issue is. If you don't have time, Ill try to find some on my spare time, but not sure I will be able to...

EverettBerry commented 2 years ago

@V0lantis I just opened a PR for this with the two fixes you called out. The console error was caused by the datatables default sort being initialized on a column that didn't exist in the cache pricing page. It's actually strange because it does not appear to me that any default sort order is being applied to the live site, much less sorting on linux price which is what the comment in default.js says it is doing. I'll investigate this later.