search

vantage-sh / ec2instances.info

Amazon EC2 instance comparison site
https://ec2instances.info
MIT License
5.13k stars 579 forks source link

Cost Display Inconsistency when Filtering #626

Closed miketwo closed 1 year ago

miketwo commented 2 years ago

Problem: After switching the cost to "Annually", costs are occassionally displayed as hourly. Steps to reproduce: I can't quite figure out what triggers it, but it happens when I'm filtering by API Name. See the gifs below for some examples. Browser:

Google Chrome | 100.0.4896.127 (Official Build) (64-bit) (cohort: Stable)
Revision | ff0d0695743e65305d7194f9bd309e5e1c824aa0-refs/branch-heads/4896_88@{#4}
OS | Windows 10 Version 21H1 (Build 19043.1645)
JavaScript | V8 10.0.139.15
User Agent | Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/100.0.4896.127 Safari/537.36

cost_discrepancy

cost_switching

miketwo commented 2 years ago

My guess is that the cost selection changes what's on-screen, but if the filter is broadened, the "new" entries are not displayed correctly.

EverettBerry commented 2 years ago

Your guess as to what’s happening looks right. I’ll see if I can get a consistent repro and post it.

EverettBerry commented 1 year ago

What's happening here is that in each gif the rows shown on the page don't change. As in, it's the same 1 row in the first gif and same 5 rows in the second gif. The code looks for new rows to update and so when it doesn't find any it skips the update and the rows get reset to the default value.

There's a seemingly related issue where you can have a URL like https://instances.vantage.sh/?cost_duration=monthly and while the displayed data will be monthly the dropdown will show hourly.

EverettBerry commented 1 year ago

Same issue as #687