Sometimes it shows some old filtering with no clear indication of the fact that the filter is applied.

vantage-sh / ec2instances.info

Amazon EC2 instance comparison site

https://ec2instances.info

MIT License

5.19k stars 585 forks source link

Sometimes it shows some old filtering with no clear indication of the fact that the filter is applied. #632

Closed alexey-milovidov closed 1 year ago

alexey-milovidov commented 2 years ago

Maybe it is saved the filters into the local storage or cookies. But I don't see what the filter is.

EverettBerry commented 2 years ago

Yes, this is certainly a UX thing we want to improve. Can you try pressing Clear Filters and see if that resets?

alexey-milovidov commented 2 years ago

Yes, it helps.

EverettBerry commented 2 years ago

Ok thanks, closing this for now but stay tuned for some improvements in this area.

simsla-ml6 commented 2 years ago

Some kind of filter is applied every time I load/refresh the page. i.e. it's not just an old filter that's too sticky.

EverettBerry commented 2 years ago

@simsla-ml6 if you press "Clear Filters" does it do help?

simsla-ml6 commented 2 years ago

It does, until I refresh.

EverettBerry commented 2 years ago

Ok interesting - can you post a screen recording or describe in more detail then behavior you're seeing?

simsla-ml6 commented 2 years ago

I was just trying to take a screen recording and am now unable to reproduce. 😅

Disregard, I might've been doing something stupid.

EverettBerry commented 2 years ago

No problem! I do think this a UX issue the way this works but we need to find a way to improve it while maintaining backwards compatibility for the folks who rely on this.

One way could be to add a save button. Right now the filter state is saved in local storage automatically.

simsla-ml6 commented 2 years ago

One issue is that when the list is filtered using one of the input boxes (e.g. API Name), the filter persists but the input box content does not.

e.g. in the below screenshot, a "c4" filter persists, but it's not clear from the UI which filter (if any) is in effect.

EverettBerry commented 2 years ago

That's a bug, mind opening an issue for this?

EverettBerry commented 2 years ago

Possibly related to #632 and #626

simsla-ml6 commented 2 years ago

Yes, I think it's probably the same as what @alexey-milovidov was describing when he created the current issue (#632).

To reproduce:

Clear Filters
Enter something in the API Name field
Refresh or browse to the site again

What should happen:

filter state matching with form state

What happens:

filter is in effect, but not visible in input field

MacOS 12.3 (21E230) -- M1 cpu Chrome Version 102.0.5005.115 (Official Build) (arm64) No errors / warnings in the console.

EverettBerry commented 2 years ago

Also happening in #650

EverettBerry commented 1 year ago

This is an example of this not happening,

When we loop through each column on page load we can check columns in Local Storage and fill in the field.

LocalStorage can be read using the state.loaded() api from DataTables, https://datatables.net/reference/api/state.loaded()

EverettBerry commented 1 year ago

This fix would also address #499