vantage-sh / ec2instances.info

Amazon EC2 instance comparison site
https://ec2instances.info
MIT License
5.11k stars 578 forks source link

add spot interrupt info to linux/windows instances where applicable #657

Closed jpetrucciani closed 7 months ago

jpetrucciani commented 2 years ago

This PR adds some spot interrupt advisor information to the instances where we can access that info!

Currently, these are added as the literal associated with the enum on their resource for pct_interrupt, but we can adjust if we'd like. This also adds a pct_savings_od representing the percentage savings over On Demand for that instance type in the given region.

I'm not super tied to any particular naming convention for these, so I'm open to suggestions!

EverettBerry commented 2 years ago

Like Ben said in slack, very nice little function that gets this done. For the frontend, my initial thought is just to add columns for this. I might dig around a bit to see what the most common term for these are. But excited to merge this! I should have a frontend commit in the next few days.