vantage-sh / ec2instances.info

Amazon EC2 instance comparison site
https://ec2instances.info
MIT License
5.07k stars 578 forks source link

Selecting rows can sometimes fail #707

Closed EverettBerry closed 11 months ago

EverettBerry commented 11 months ago

There's a bug that I haven't fully repro'd yet (but was reported as well by a firefox user) where clicking on the rows does not highlight them.

It may be time to actually move to checkboxes for the rows on the left instead of clicking on rows to select them. The mobile PR actually has some code for this.

EverettBerry commented 11 months ago

There's at least 2 scenarios where this happens, unified by the fact that a smaller number of rows than normal is displayed on page load.

There's some issue with the way we are assigning the highlight rows functionality on page load where the number of rows displayed is less than the full amount.