vantage-sh / ec2instances.info

Amazon EC2 instance comparison site
https://ec2instances.info
MIT License
5.19k stars 585 forks source link

AWS instances - "Max Throughput (MB/s) on EBS" displays wrong values for EBS burstable instances #747

Open stavistavi opened 2 months ago

stavistavi commented 2 months ago

"Max Throughput (MB/s) on EBS" should be 1/8 of "Max Bandwidth (Mbps)" (bits to Bytes division by "8").

Instead, the value seems to be a copy of Baseline Throughput (MB/s)" value.

AWS API is returning correct info:

aws ec2 describe-instance-types --instance-types t3.xlarge --region us-east-2

"EbsInfo": {
                "EbsOptimizedSupport": "default",
                "EncryptionSupport": "supported",
                "EbsOptimizedInfo": {
                    "BaselineBandwidthInMbps": 695,
                    "BaselineThroughputInMBps": 86.875,
                    "BaselineIops": 4000,
                    "MaximumBandwidthInMbps": 2780,
                    "MaximumThroughputInMBps": 347.5,
            "MaximumIops": 15700

where https://instances.vantage.sh/aws/ec2/t3.xlarge returns 86.875 as Max Throughput (MB/s).

Did a quick look into code and I believe the issue is here: https://github.com/vantage-sh/ec2instances.info/blob/00a11b403b44fb1033c3baa101d295812de16008/ec2.py#L395C1-L396C1

stavistavi commented 2 months ago

@NikhilKumar77777 My point is that there is a wrong information displayed on public website https://instances.vantage.sh/

Not sure how this can be fixed by whatever is in that RAR archive

coldfire3000 commented 1 month ago

Also seeing this issue. m5.large and others list the baseline EBS throughput and the max EBS throughput as 81.25MB/s, when the max/burst should be higher, for m5.large should be 593.75MB/s as per https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/ebs-optimized.html

coldfire3000 commented 1 month ago

Also concur with stavistavi that line 395 of the code is re-referencing 'BaselineThroughputInMBps' again, when it should be using 'MaximumThroughputInMBps'.