vantage6 / vantage6-workshop

https://vantage6.github.io/vantage6-workshop/
Other
0 stars 0 forks source link

Added challenge to chapter 1 #93

Closed dsmits closed 2 months ago

github-actions[bot] commented 2 months ago

Thank you!

Thank you for your pull request :smiley:

:robot: This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

Rendered Changes

:mag: Inspect the changes: https://github.com/vantage6/vantage6-workshop/compare/md-outputs..md-outputs-PR-93

The following changes were observed in the rendered markdown documents:

 chap1_introduction_FL.md                        |  58 +++++++++++++++++++++++-
 fig/chapter1/secret_sharing_example_1.jpg (new) | Bin 0 -> 66325 bytes
 fig/chapter1/secret_sharing_example_2.jpg (new) | Bin 0 -> 32785 bytes
 fig/chapter1/secret_sharing_example_3.jpg (new) | Bin 0 -> 37683 bytes
 md5sum.txt                                      |   2 +-
 5 files changed, 57 insertions(+), 3 deletions(-)
What does this mean? If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

:stopwatch: Updated at 2024-09-12 09:46:45 +0000

dsmits commented 2 months ago

@hcadavid I added an exercise about the hacker that you were suggesting. I kept the old exercise because I'm not trying to make a point about the security of secret sharing. The point is about whether aggregation in itself preserves privacy. I hope that i have made it more clear in this way.

I also added the pictures you requested.

hcadavid commented 2 months ago

@dsmits The example and the challenges are indeed quite clear now, they look and read nice! Should I merge the PR? or do you want @frankcorneliusmartin to add his review first?