Description
The validators defined here are used to check that good values are provided for new node and server configurations created with vnode new and vserver new.
These validators are currently not used consistently: some validation checks are already in the code (e.g. the name is checked immediately if it already exists in the vnode new function itself), while the validators are only applied afterward.
We should probably do either of the following
Use the validators consistently
Remove the validators, and move any checks to the code.
The main reason in favor for the second option is that the validators are only applied at the very end of filling out the configuration, which gives a poor user experience if one of the first values was already wrong but one is only told so at the very end.
bartvanb
commented
3 months ago
Description The validators defined here are used to check that good values are provided for new node and server configurations created with
vnode newandvserver new.These validators are currently not used consistently: some validation checks are already in the code (e.g. the name is checked immediately if it already exists in the
vnode newfunction itself), while the validators are only applied afterward.We should probably do either of the following
The main reason in favor for the second option is that the validators are only applied at the very end of filling out the configuration, which gives a poor user experience if one of the first values was already wrong but one is only told so at the very end.