search

vantemoon / pe

0 stars 0 forks source link

No error message is shown when trying to removing non-existing module from module lists #4

Open vantemoon opened 1 year ago

vantemoon commented 1 year ago

No error message is shown when the user executes "module user rm/ST2334" and ST2334 is not in the user's module lists.

nus-se-script commented 1 year ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Removing a module that a contact doesn't currently take does not throw an exception

  1. Ensure that the contact is not currently taking gea1000

  2. module 1 curr/CS2101 prev/CS2030S plan/CS2102 rm/GEA1000

  3. No exception is thrown

Screenshot 2022-11-11 at 4.41.17 PM.png

[original: nus-cs2103-AY2223S1/pe-interim#1922] [original labels: severity.Medium type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

It is written in the developer guide that this is a design consideration. Regardless of whether the module existed or not, it would have been removed at the end of the execution. Even if it is considered a bug, it should not be medium but low severity.

Screenshot 2022-11-13 at 9.16.06 PM.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I don't think the justification provided in DG is reasonable as even iterating though a list of 100 modules won't make the program significantly slower.