search

vanthomiy / Sleepest

MIT License
3 stars 0 forks source link

Sleep duration can be setup way to high #154

Closed vanthomiy closed 3 years ago

vanthomiy commented 3 years ago

The check works but the callback to update the ui dont work.

FabiM96 commented 3 years ago

Screenshot_2021-09-30-19-33-02-637_com.sleepestapp.sleepest.jpg

Unfortunately it's still one hour to high. 15 hours is not possible, but 14.

vanthomiy commented 3 years ago

what is your sleep time start?

FabiM96 commented 3 years ago

17:00. Does it just depend on sleeptime settings without checking actual time?

vanthomiy commented 3 years ago

Yes, why should this check the actual time ? You can set your alarm for tomorrow and it will check if sleep start, duration and latest wakeup match together. There is no need for checking the actual time

FabiM96 commented 3 years ago

But if the user changes the sleep duration in sleep time, it is possible to set a sleep duration which is not possible to reach and I think we can prevent this.

vanthomiy commented 3 years ago

I think this is not the way to go. If the user wants to change the sleep duration in the alarm and this also coincides with the sleeping times, he should be able to do so. And if he should already sleep because of his changed sleep time he should be notificated by the banner? I think that is already implemented.

FabiM96 commented 3 years ago

I think it is the right way to prevent this. We tried all the time to prevent impossible sleep time settings so why not in this case. The notification information is working but it's not meant for that case but for transgression of the latest time to fall asleep.