vanutp / tgbridge

A feature-rich multiloader mod to sync Telegram and Minecraft chats
https://modrinth.com/mod/tgbridge
MIT License
28 stars 3 forks source link

Displaying Username Only on Joining and Death Game Event when using ops-name-color in Essentials on Paper/Purpur #22

Open Euk0r opened 3 hours ago

Euk0r commented 3 hours ago

Version of plugin: 0.4.4

Tested on:

  1. Paper version git-Paper-196 (MC: 1.20.1) (Implementing API version 1.20.1-R0.1-SNAPSHOT) (Git: 773dd72)
  2. Paper version git-Paper-497 (MC: 1.20.4) (Implementing API version 1.20.4-R0.1-SNAPSHOT) (Git: d8d54d9 on ver/1.20.4)
  3. Purpur Version: 1.21.1-2321-2eaea6a (MC: 1.21.1)

    Problem

    It has been observed that the player's username is displayed in Telegram messages upon the joining and death events. Everything else is working fine. For the lang.yml file, the pre-edited language from the following link was used: link image For chat plugins, Chatty was used on the first and third servers. No chat plugin was used on the second server.

If you need additional information, please ask, and I will provide it. Thank you

vanutp commented 2 hours ago

Do you have any other plugins installed? I can't reproduce this on git-Paper-497 (MC: 1.20.4) with only tgbridge installed.

Euk0r commented 1 hour ago

On Paper 1.20.4 i have: [19:51:01 INFO]: PM | Plugins (32): [19:51:01 INFO]: - AdvancedPortals 1.0.0 [19:51:01 INFO]: - BKCommonLib 1.21.1-v1-SNAPSHOT [19:51:01 INFO]: - Citizens 2.0.33-SNAPSHOT (build 3382) [19:51:01 INFO]: - CommandWhitelist 2.10.0 [19:51:01 INFO]: - DecentHolograms 2.8.11 [19:51:01 INFO]: - Dexterity 1.1.4 [19:51:01 INFO]: - emotecraft 2.5.1 [19:51:01 INFO]: - Essentials 2.21.0-dev+111-b54c8c1 [19:51:01 INFO]: - EssentialsSpawn 2.21.0-dev+111-b54c8c1 [19:51:01 INFO]: - ExploitFixer 2.6.0 [19:51:01 INFO]: - FastAsyncWorldEdit 2.11.2-SNAPSHOT-888;75fb1cb [19:51:01 INFO]: - floodgate 2.2.3-SNAPSHOT (b111-3db8e59) [19:51:01 INFO]: - GSit 1.10.0 [19:51:01 INFO]: - GUIPlus 2.92 [19:51:01 INFO]: - HamsterAPI 0.2.4 [19:51:01 INFO]: - IllegalStack 2.9.12-SNAPSHOT-01 [19:51:01 INFO]: - Images 2.5.1 [19:51:01 INFO]: - LuckPerms 5.4.141 [19:51:01 INFO]: - My_Worlds 1.20.6-v1 [19:51:01 INFO]: - MyCommand 5.7.4 [19:51:01 INFO]: - PlaceholderAPI 2.11.6 [19:51:01 INFO]: - PlasmoVoice 2.0.10 [19:51:01 INFO]: - PluginManager 2.8.1 [19:51:01 INFO]: - ProtocolLib 5.2.0-SNAPSHOT-679 [19:51:01 INFO]: - spark 1.10.105 [19:51:01 INFO]: - TAB 4.1.7 [19:51:01 INFO]: - tgbridge 0.4.4 [19:51:01 INFO]: - Vault 1.7.3-b131 [19:51:01 INFO]: - ViaBackwards 5.0.3 [19:51:01 INFO]: - ViaVersion 5.0.3 [19:51:01 INFO]: - VoidTeleportPlus 3.5.5 [19:51:01 INFO]: - WorldGuard 7.0.9+5934e49

I'll try to figure out which plugin is causing the problem

Euk0r commented 34 minutes ago

I found the problem. When using the default parameter ops-name-color: '4' in the Essentials plugin, the player's name (in this case, with operator rights) does not appear in many instances in the plugin. If you set ops-name-color: 'none', everything is fine. I can assume that this happens due to string filtering when there are extraneous characters (after the Essentials plugin, the nickname looks like §4%player_name%§r), but this is just an assumption. I hope this information was helpful.

vanutp commented 19 minutes ago

Thanks! I will work on this soon