search

vanvalenlab / deepcell-applications

Run DeepCell Applications
Other
8 stars 6 forks source link

add imagecodecs and update deepcell-tf to 0.12.4 #35

Closed aandytu closed 1 year ago

aandytu commented 1 year ago

Added imagecodecs to requirement.txt to allow tiffile to load lzw-compressed images. Also some general update to the latest version of deepcell.

rossbar commented 1 year ago

I'm +1 for these updates, though I'd like to separate them out into separate patch releases just in case there's something unexpected related to bumping the deepcell-tf version (the nuclear segmentation model got a bump in 0.12.4, for example).

From the discussion in #26 it seems like there were hopes that this would be resolved with updates to Python/tensorflow but that appears not to have been the case. I agree we can just add the extra dependency to unblock this use-case.

I will aim cut a 0.4.1 release later today.

rossbar commented 1 year ago

Thanks for pushing this @aandytu .

I'm working on a release now. As mentioned above (and now further reinforced by changes in dependencies) I'm going to put off bumping the deepcell version; therefore I will close this PR in favor #36 (attribution is preserved).

aandytu commented 1 year ago

thanks @rossbar!