vanvalenlab / deepcell-tf

Deep Learning Library for Single Cell Analysis
https://deepcell.readthedocs.io
Other
413 stars 95 forks source link

SiameseDataGenerator should be tolerant of poorly formatted input data #151

Closed MekWarrior closed 3 years ago

MekWarrior commented 5 years ago

The tracking data generator should log and throw a custom error when data is poorly/incorrectly formatted. Ideally, it should be fault tolerant. At minimum it should throw an exception and fail on purpose.

willgraf commented 3 years ago

I would like to close this issue as the SiameseDataGenerator already checks for:

I think that these validations are sufficient, even though they do not validate all of the daughter data. Because we do not do label validation for instance segmentation models, I do not see why we need to validate the lineage data here in the data generator.

I could see a use for this in deepcell-tracking though.

willgraf commented 3 years ago

I'm going to close this issue as the SiameseDataGenerator does do some validation, but full .trk or lineage.json validation should live in deepcell-tracking. This is now being tracked in vanvalenlab/deepcell-tracking#51.