Open willgraf opened 3 years ago
Copied below for convenience:
That said, there are a few critical pieces of the code that are currently untested:
deepcell_tracking.utils.Track
is missing tests for assigning both same and daughter intemporal_adj_matrix
as well as the invalid (-1
) values.deepcell_tracking.tracking.CellTracker
is missing several important tests:
- The entire block of
_update_tracks
that handles new division events- The block of
_get_parent
that assigns parents- The handling of parents in
_track_to_graph
.- False Positive logic in
postprocess
and_review_candidate_nodes
- The entirety of
_remove_false_pos
is untested.deepcell_tracking.isbi_utils.benchmark_division_performance
is untested.
Now that we are running tests on several Python + OS combinations, we can see that there are some random fluctuations in test results. I've identified several cases where some conditions are not run, though there may be others:
The tests should be amended to directly cause these situations and assert that they are removed from the output.