Closed R-Ding closed 3 years ago
Code changes looks good. Seems to run a bit slower, which is surprising but in my one live test it did replicate the results of the original code.
If you could also add a test for benchmark_division_performance
, that would be very helpful. It's the last function in the file that is untested.
Looks great! Very pleased with where it is - just one last small change for deprecation warning.
Thanks for all the help!
What
isbi_utils_tests
to test the new approachWhy