vanvalenlab / deepcell-tracking

Track cells and build cell lineages
Other
29 stars 6 forks source link

Change `isbi_utils` from writing files to comparing in memory #67

Closed R-Ding closed 3 years ago

R-Ding commented 3 years ago

What

Why

MekWarrior commented 3 years ago

Code changes looks good. Seems to run a bit slower, which is surprising but in my one live test it did replicate the results of the original code.

willgraf commented 3 years ago

If you could also add a test for benchmark_division_performance, that would be very helpful. It's the last function in the file that is untested.

R-Ding commented 3 years ago

Looks great! Very pleased with where it is - just one last small change for deprecation warning.

Thanks for all the help!