search

vanvalenlab / deepcell-tracking

Track cells and build cell lineages
Other
29 stars 6 forks source link

windows python 3.9.2 deepcell install problem resolved #86

Closed zverozabr closed 3 years ago

zverozabr commented 3 years ago

problem in https://github.com/vanvalenlab/deepcell-tracking/issues/85

(Fixes #85)

willgraf commented 3 years ago

It looks like pathlib2 is no longer supported, so I'm not sure that this is the best fix for the issue. Maybe we can just pin the version of pathlib to prevent the breaking change in the latest release? (I'm assuming that the problem is a new release issue).

EDIT: there is no new release so I'm not sure why this is suddenly breaking. Maybe a dependency of pathlib had a breaking change instead.

zverozabr commented 3 years ago

pathlib is included in python, but for compatibility with old versions, I added the latest version that I found, in general, you can remove it altogether from the setup

zverozabr commented 3 years ago

okay may be it only my problem, but this fix help me to install deepcell==0.11.0

willgraf commented 3 years ago

Great, thanks for the change - it seems pathlib2 would have been fine to leave included, but since pathlib is included in Python 3.4+ (and only Python 3.6+ is supported), there is no good reason to include it in setup.py.

I think this is also the cause of build failures in deepcell-tf. I'm not quite sure what the root cause is, but this looks to be a good fix.