vanvalenlab / kiosk-console

DeepCell Kiosk Distribution for Kubernetes on GKE and AWS
https://deepcell-kiosk.readthedocs.io
Other
35 stars 6 forks source link

dnsSolver01 Service Account can have a maximum number of keys. #391

Closed willgraf closed 3 years ago

willgraf commented 4 years ago

Describe the bug When CERTIFICATE_MANAGER_ENABLED a service account for the DNS solver is created, and a secret key is added onto the service account. Because this service account is not deleted, and the key is never removed, repeated deployments with the same account can fail due to a RESOURCE_EXHAUSTED error from gcloud.

To Reproduce Steps to reproduce the behavior:

  1. Run make gke/create/certificate-manager-sa many times in a row.
  2. Eventually the command will fail due to too many keys.

Expected behavior The key should either be removed from the service account on cluster destruction, or the service account should be deleted entirely.

willgraf commented 3 years ago

Closed by #400