vanvalenlab / kiosk-console

DeepCell Kiosk Distribution for Kubernetes on GKE and AWS
https://deepcell-kiosk.readthedocs.io
Other
35 stars 6 forks source link

Update helmfile defaults for faster helm deployments. #404

Closed willgraf closed 3 years ago

willgraf commented 3 years ago

All of our helmfiles were using the same default values, specifically timeout: 600. This PR updates those defaults by:

willgraf commented 3 years ago

Please see below for an example of the helmfile failure output/warnings.

Screen Shot 2020-12-11 at 1 48 30 PM
MekWarrior commented 3 years ago

I like alot of what is there but I do have a couple concerns. First, we need to make sure docs are clear on where to run the helmfile -l name=... command. Second, the message seems contradictory. On the one hand we say "Not all .... successfully deployed" but at the end we say "...created successfully." This could cause confusion and the early message may be disregarded - and subsequently lost to the logs.