Closed willgraf closed 3 years ago
Please see below for an example of the helmfile failure output/warnings.
I like alot of what is there but I do have a couple concerns. First, we need to make sure docs are clear on where to run the helmfile -l name=...
command. Second, the message seems contradictory. On the one hand we say "Not all .... successfully deployed" but at the end we say "...created successfully." This could cause confusion and the early message may be disregarded - and subsequently lost to the logs.
All of our helmfiles were using the same default values, specifically
timeout: 600
. This PR updates those defaults by:force: true
was removed for all helm deployments, which was causing some issues with helm3.atomic: true
andcleanupOnFail: true
were added to all releases. Having helm do the cleanup lets us clean up some of our deployment wrapper script.helm delete
as each helmfile hasatomic
andcleanupOnFailure
enabled. (Fixes #349)