vanviegen / hue-thief

Factory reset Philips Hue bulbs using an EZSP-based Zigbee USB stick. After a reset, bulbs can easily join any type of compatible bridge.
GNU General Public License v3.0
178 stars 20 forks source link

add Docker instructions, and more devices #8

Closed artmg closed 4 years ago

artmg commented 4 years ago

Hi Frank,

thanks for an awesome project, that seems very popular in the Home Automation community. As I developed a Dockerfile with instructions I thought I would share that with you and your userbase.

No code change so not testing issues. If however you'd like any of the wording changed I'm open to suggestions.

I, and my lightbulbs, really appreciate how you have liberated us :) Cheers, Art

vanviegen commented 4 years ago

Hi Art,

Nice work!

I'm not much of a Docker expert, but wouldn't it make more sense to just put the Dockerfile in the registry, and provide two command line invocations (build and run) in the README file here?

They may take our lights, but they'll never take our freedom! :-)

--Frank

artmg commented 4 years ago

Sure, Frank, that should work

I didn't want to impact your codebase, but what you say makes complete sense. We can put this PR on hold and hopefully I'll get around to doing a different branch soon

Art

artmg commented 4 years ago

replaced with PR #9