vanvught / rpidmx512

Orange Pi DMX512 / RDM / MIDI / OSC / Art-Net / WS28xx / L6470 / Stepper / TLC59711 / PCA9685 / Servo / PWM / TCNet / SMPTE / RDMNet / LLRP / GD32 / GigaDevice / Raspberry Pi
http://www.orangepi-dmx.org/
MIT License
391 stars 108 forks source link

lib-rdm/include/rdmhandler.h:43:10: warning: Excessive padding in 'RDMHandler::TPidDefinition' (10 padding bytes, where 2 is optimal). #205

Closed vanvught closed 2 years ago

vanvught commented 3 years ago
lib-rdm/src lib-rdm/include include-rdm/include lib-rdm/include lib-rdm/src/rdmhandler.cpp
10 warnings generated.
lib-rdm/include/rdmhandler.h:43:10: warning: Excessive padding in 'RDMHandler::TPidDefinition' (10 padding bytes, where 2 is optimal).
Optimal fields order:
pGetHandler,
pSetHandler,
nPid,
nGetArgumentSize,
bIncludeInSupportedParams,
bRDM,
bRDMNet,
consider reordering the fields or adding explicit padding members [clang-analyzer-optin.performance.Padding]
        typedef struct {
                ^
lib-rdm/include/rdmhandler.h:43:10: note: Excessive padding in 'RDMHandler::TPidDefinition' (10 padding bytes, where 2 is optimal). Optimal fields                                                order: pGetHandler, pSetHandler, nPid, nGetArgumentSize, bIncludeInSupportedParams, bRDM, bRDMNet, consider reordering the fields or adding expli                                               cit padding members

cc: @hippyau

vanvught commented 2 years ago

This is ROM space. No need for cleanup.