vapor-community / Imperial

Federated Authentication with OAuth providers
MIT License
155 stars 48 forks source link

authURL constructed in GoogleRouter is invalid with multiple scopes #21

Closed edmw closed 5 years ago

edmw commented 5 years ago

Spaces must be url encoded to form a valid url. While most browsers will correctly process a Location header with such an url, other components can and will break, for example URL(string: googleRouter.authURL) will return nil.

https://github.com/vapor-community/Imperial/blob/c1b6b21453f7cb2863d695abdef881bc2cd127dc/Sources/Imperial/Services/Google/GoogleRouter.swift#L14