Holding Strong Reference to Client

vapor-community / Imperial

Federated Authentication with OAuth providers

MIT License

155 stars 48 forks source link

Holding Strong Reference to Client #26

Closed calebkleveter closed 3 years ago

calebkleveter commented 5 years ago

Somewhere we appear to be holding onto Client when the container is released, cause us to hit a fatalError in Vapor:

Fatal error: If you encounter this error, you are holding on to a client after de-initializing your Application. This is usually a bad idea.: file /tmp/build_769e8eccc58c3bc6a5daf7c3903d82c0/.build/checkouts/vapor.git-4085136337785951737/Sources/Vapor/Client/FoundationClient.swift, line 16

This is a design issue on our side.

0xTim commented 5 years ago

This should be fixed by vapor/vapor#1896

0xTim commented 3 years ago

This should be fixed in Vapor 4