Use hexEncodedString() from Vapor to avoid duplicated hex() conflict

vapor-community / Imperial

Federated Authentication with OAuth providers

MIT License

153 stars 48 forks source link

Use hexEncodedString() from Vapor to avoid duplicated hex() conflict #62

Closed m-barthelemy closed 4 years ago

m-barthelemy commented 4 years ago

A change begining with Vapor 4.0.0-rc.3.5 moves the hex extension property from Collection to Sequence, which makes it clash with Imperial's own hex extension property.

Note: Vapor also has hex which just calls hexEncodedString(). No idea if one should be preferred over the other.

Since Vapor is a dependency of Imperial, I figured out their implementation could just be reused here.

0xTim commented 4 years ago

@m-barthelemy how did you get this to compile?

0xTim commented 4 years ago

Ignore me, Xcode not picking the latest versions!

m-barthelemy commented 4 years ago

I feel your pain, Xcode + Swift + SPM is still a pain in some areas, this is one of those. I don't personally use the Shopify oauth, but I saw there was a unit test for the hex thing, and I made sure it passed before creating the PR :)