vapor-community / PassKit

🎟️ πŸ“¦ A package for creating passes and orders for Apple Wallet with Vapor.
https://swiftpackageindex.com/vapor-community/PassKit
MIT License
64 stars 11 forks source link

Version 0.6.0 #10

Closed fpseverino closed 1 month ago

fpseverino commented 3 months ago
codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 95.95238% with 17 lines in your changes missing coverage. Please review.

Project coverage is 94.36%. Comparing base (99fa653) to head (19b3af1). Report is 6 commits behind head on main.

Files Patch % Lines
...urces/Passes/Models/UserPersonalizationModel.swift 80.00% 8 Missing :warning:
Sources/Passes/PassesServiceCustom.swift 97.54% 5 Missing :warning:
Sources/Orders/OrdersServiceCustom.swift 97.70% 3 Missing :warning:
Sources/Passes/Models/PassModel.swift 80.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #10 +/- ## ========================================== + Coverage 0.00% 94.36% +94.36% ========================================== Files 11 33 +22 Lines 517 1012 +495 ========================================== + Hits 0 955 +955 + Misses 517 57 -460 ``` | [Files](https://app.codecov.io/gh/vapor-community/PassKit/pull/10?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor-community) | Coverage Ξ” | | |---|---|---| | [Sources/Orders/DTOs/OrdersForDeviceDTO.swift](https://app.codecov.io/gh/vapor-community/PassKit/pull/10?src=pr&el=tree&filepath=Sources%2FOrders%2FDTOs%2FOrdersForDeviceDTO.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor-community#diff-U291cmNlcy9PcmRlcnMvRFRPcy9PcmRlcnNGb3JEZXZpY2VEVE8uc3dpZnQ=) | `100.00% <100.00%> (ΓΈ)` | | | [Sources/Orders/Models/Concrete Models/Order.swift](https://app.codecov.io/gh/vapor-community/PassKit/pull/10?src=pr&el=tree&filepath=Sources%2FOrders%2FModels%2FConcrete+Models%2FOrder.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor-community#diff-U291cmNlcy9PcmRlcnMvTW9kZWxzL0NvbmNyZXRlIE1vZGVscy9PcmRlci5zd2lmdA==) | `100.00% <ΓΈ> (ΓΈ)` | | | [Sources/Orders/Models/OrderModel.swift](https://app.codecov.io/gh/vapor-community/PassKit/pull/10?src=pr&el=tree&filepath=Sources%2FOrders%2FModels%2FOrderModel.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor-community#diff-U291cmNlcy9PcmRlcnMvTW9kZWxzL09yZGVyTW9kZWwuc3dpZnQ=) | `80.00% <ΓΈ> (ΓΈ)` | | | [Sources/Orders/OrdersDelegate.swift](https://app.codecov.io/gh/vapor-community/PassKit/pull/10?src=pr&el=tree&filepath=Sources%2FOrders%2FOrdersDelegate.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor-community#diff-U291cmNlcy9PcmRlcnMvT3JkZXJzRGVsZWdhdGUuc3dpZnQ=) | `100.00% <ΓΈ> (ΓΈ)` | | | [Sources/Orders/OrdersError.swift](https://app.codecov.io/gh/vapor-community/PassKit/pull/10?src=pr&el=tree&filepath=Sources%2FOrders%2FOrdersError.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor-community#diff-U291cmNlcy9PcmRlcnMvT3JkZXJzRXJyb3Iuc3dpZnQ=) | `100.00% <ΓΈ> (ΓΈ)` | | | [Sources/Orders/OrdersService.swift](https://app.codecov.io/gh/vapor-community/PassKit/pull/10?src=pr&el=tree&filepath=Sources%2FOrders%2FOrdersService.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor-community#diff-U291cmNlcy9PcmRlcnMvT3JkZXJzU2VydmljZS5zd2lmdA==) | `100.00% <100.00%> (ΓΈ)` | | | [Sources/PassKit/DTOs/ErrorLogDTO.swift](https://app.codecov.io/gh/vapor-community/PassKit/pull/10?src=pr&el=tree&filepath=Sources%2FPassKit%2FDTOs%2FErrorLogDTO.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor-community#diff-U291cmNlcy9QYXNzS2l0L0RUT3MvRXJyb3JMb2dEVE8uc3dpZnQ=) | `100.00% <100.00%> (ΓΈ)` | | | [Sources/PassKit/DTOs/RegistrationDTO.swift](https://app.codecov.io/gh/vapor-community/PassKit/pull/10?src=pr&el=tree&filepath=Sources%2FPassKit%2FDTOs%2FRegistrationDTO.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor-community#diff-U291cmNlcy9QYXNzS2l0L0RUT3MvUmVnaXN0cmF0aW9uRFRPLnN3aWZ0) | `100.00% <100.00%> (ΓΈ)` | | | [Sources/PassKit/Models/DeviceModel.swift](https://app.codecov.io/gh/vapor-community/PassKit/pull/10?src=pr&el=tree&filepath=Sources%2FPassKit%2FModels%2FDeviceModel.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor-community#diff-U291cmNlcy9QYXNzS2l0L01vZGVscy9EZXZpY2VNb2RlbC5zd2lmdA==) | `80.00% <ΓΈ> (ΓΈ)` | | | [Sources/Passes/Models/Concrete Models/Pass.swift](https://app.codecov.io/gh/vapor-community/PassKit/pull/10?src=pr&el=tree&filepath=Sources%2FPasses%2FModels%2FConcrete+Models%2FPass.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor-community#diff-U291cmNlcy9QYXNzZXMvTW9kZWxzL0NvbmNyZXRlIE1vZGVscy9QYXNzLnN3aWZ0) | `100.00% <100.00%> (ΓΈ)` | | | ... and [9 more](https://app.codecov.io/gh/vapor-community/PassKit/pull/10?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor-community) | | ... and [6 files with indirect coverage changes](https://app.codecov.io/gh/vapor-community/PassKit/pull/10/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor-community)
fpseverino commented 2 months ago

I'm assuming we have an issue open on Swift Crypto for this?

Cory Benfield told me on Slack that encrypted PEM keys aren't supported because they use old encryption schemes (I assume DES) that they don't plan to support in Swift Crypto