Closed fpseverino closed 3 months ago
Attention: Patch coverage is 0%
with 276 lines
in your changes missing coverage. Please review.
Project coverage is 0.00%. Comparing base (
99fa653
) to head (6e6c69f
). Report is 3 commits behind head on main.
I know this was merged in already but wanted to voice my concerns. Also, tests?
Thanks for the feedback Paul! I'll add tests for bundle signing, but for updating passes and orders I think a real device is needed.
PKErrorLog
model, where thecreated_at
FieldKey
didn't coincide in the model and in the migration.authenticationToken
unique for each pass, as requested by the Wallet documentation, improving security.PassKit
for the types shared between thePasses
and the upcomingOrders
modules.PassJSON
protocol to help build thepass.json
.Orders
target.