vapor-community / PassKit

🎟️ πŸ“¦ A package for creating passes and orders for Apple Wallet with Vapor.
https://swiftpackageindex.com/vapor-community/PassKit
MIT License
64 stars 11 forks source link

Version 0.4.0 #8

Closed fpseverino closed 3 months ago

fpseverino commented 3 months ago
codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 276 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (99fa653) to head (6e6c69f). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #8 +/- ## ===================================== Coverage 0.00% 0.00% ===================================== Files 11 27 +16 Lines 517 614 +97 ===================================== - Misses 517 614 +97 ``` | [Files](https://app.codecov.io/gh/vapor-community/PassKit/pull/8?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor-community) | Coverage Ξ” | | |---|---|---| | [Sources/PassKit/Models/DeviceModel.swift](https://app.codecov.io/gh/vapor-community/PassKit/pull/8?src=pr&el=tree&filepath=Sources%2FPassKit%2FModels%2FDeviceModel.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor-community#diff-U291cmNlcy9QYXNzS2l0L01vZGVscy9EZXZpY2VNb2RlbC5zd2lmdA==) | `0.00% <ΓΈ> (ΓΈ)` | | | [Sources/PassKit/Models/ErrorLogModel.swift](https://app.codecov.io/gh/vapor-community/PassKit/pull/8?src=pr&el=tree&filepath=Sources%2FPassKit%2FModels%2FErrorLogModel.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor-community#diff-U291cmNlcy9QYXNzS2l0L01vZGVscy9FcnJvckxvZ01vZGVsLnN3aWZ0) | `0.00% <ΓΈ> (ΓΈ)` | | | [Sources/Passes/Models/PassDataModel.swift](https://app.codecov.io/gh/vapor-community/PassKit/pull/8?src=pr&el=tree&filepath=Sources%2FPasses%2FModels%2FPassDataModel.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor-community#diff-U291cmNlcy9QYXNzZXMvTW9kZWxzL1Bhc3NEYXRhTW9kZWwuc3dpZnQ=) | `0.00% <ΓΈ> (ΓΈ)` | | | [...ources/Passes/Models/PassesRegistrationModel.swift](https://app.codecov.io/gh/vapor-community/PassKit/pull/8?src=pr&el=tree&filepath=Sources%2FPasses%2FModels%2FPassesRegistrationModel.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor-community#diff-U291cmNlcy9QYXNzZXMvTW9kZWxzL1Bhc3Nlc1JlZ2lzdHJhdGlvbk1vZGVsLnN3aWZ0) | `0.00% <ΓΈ> (ΓΈ)` | | | [Sources/Passes/PassesDelegate.swift](https://app.codecov.io/gh/vapor-community/PassKit/pull/8?src=pr&el=tree&filepath=Sources%2FPasses%2FPassesDelegate.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor-community#diff-U291cmNlcy9QYXNzZXMvUGFzc2VzRGVsZWdhdGUuc3dpZnQ=) | `0.00% <ΓΈ> (ΓΈ)` | | | [Sources/PassKit/URL+Extension.swift](https://app.codecov.io/gh/vapor-community/PassKit/pull/8?src=pr&el=tree&filepath=Sources%2FPassKit%2FURL%2BExtension.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor-community#diff-U291cmNlcy9QYXNzS2l0L1VSTCtFeHRlbnNpb24uc3dpZnQ=) | `0.00% <0.00%> (ΓΈ)` | | | [Sources/Orders/DTOs/OrdersForDeviceDTO.swift](https://app.codecov.io/gh/vapor-community/PassKit/pull/8?src=pr&el=tree&filepath=Sources%2FOrders%2FDTOs%2FOrdersForDeviceDTO.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor-community#diff-U291cmNlcy9PcmRlcnMvRFRPcy9PcmRlcnNGb3JEZXZpY2VEVE8uc3dpZnQ=) | `0.00% <0.00%> (ΓΈ)` | | | [Sources/Orders/Models/OrderDataModel.swift](https://app.codecov.io/gh/vapor-community/PassKit/pull/8?src=pr&el=tree&filepath=Sources%2FOrders%2FModels%2FOrderDataModel.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor-community#diff-U291cmNlcy9PcmRlcnMvTW9kZWxzL09yZGVyRGF0YU1vZGVsLnN3aWZ0) | `0.00% <0.00%> (ΓΈ)` | | | [...ources/Passes/Middleware/ApplePassMiddleware.swift](https://app.codecov.io/gh/vapor-community/PassKit/pull/8?src=pr&el=tree&filepath=Sources%2FPasses%2FMiddleware%2FApplePassMiddleware.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor-community#diff-U291cmNlcy9QYXNzZXMvTWlkZGxld2FyZS9BcHBsZVBhc3NNaWRkbGV3YXJlLnN3aWZ0) | `0.00% <0.00%> (ΓΈ)` | | | [Sources/Passes/Models/PassModel.swift](https://app.codecov.io/gh/vapor-community/PassKit/pull/8?src=pr&el=tree&filepath=Sources%2FPasses%2FModels%2FPassModel.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor-community#diff-U291cmNlcy9QYXNzZXMvTW9kZWxzL1Bhc3NNb2RlbC5zd2lmdA==) | `0.00% <0.00%> (ΓΈ)` | | | ... and [16 more](https://app.codecov.io/gh/vapor-community/PassKit/pull/8?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor-community) | |
fpseverino commented 3 months ago

I know this was merged in already but wanted to voice my concerns. Also, tests?

Thanks for the feedback Paul! I'll add tests for bundle signing, but for updating passes and orders I think a real device is needed.