search

vapor-community / mongo-driver

MongoDB driver for Fluent
28 stars 26 forks source link

Getting mongo-driver driving again #2

Closed paulrolfe closed 8 years ago

paulrolfe commented 8 years ago

This is pretty rough, just wanted to get it working. I'm hoping to get a lot of feedback on this.

tanner0101 commented 8 years ago

Woohoo. This looks really good. Can we add some tests? Some like what the MySQL Driver has: https://github.com/vapor/mysql-driver/tree/master/Tests/FluentMySQLTests

Basically we need some default Mongo configuration that the tests will connect to otherwise it errors: https://github.com/vapor/mysql-driver/blob/master/Tests/FluentMySQLTests/Utilities/MySQLDriver%2BTests.swift#L20

Then just some really simple tests to make sure everything is working https://github.com/vapor/mysql-driver/blob/master/Tests/FluentMySQLTests/MySQLDriverTests.swift#L26

paulrolfe commented 8 years ago

Tests are in! Thanks for the feedback. The tests helped me see some key errors I'd made as well. So I fixed the following as well:

tanner0101 commented 8 years ago

This looks really good. I invited you to the vapor org. If you accept, you can merge this whenever you think it's ready. Then from there we can get the mongo-provider up and running.

This is what the MySQL one looks like: https://github.com/vapor/mysql-provider

The provider basically grabs the information from the config files to setup the connection. Once that is done, people can start using Mongo in their projects! Just in time for 1.0 :D

paulrolfe commented 8 years ago

It turns out I don't have write access (did accept the org invite though, thanks!), so can't merge. But I'm satisfied with it, if you'd like to merge for me. @tannernelson

tanner0101 commented 8 years ago

Awesome! Thanks

tanner0101 commented 8 years ago

This repo didn't have the teams configured. You have write access now.