vapor-community / mongo-driver

MongoDB driver for Fluent
28 stars 26 forks source link

[WIP] Fluent2 rework #33

Closed Joannis closed 7 years ago

Joannis commented 7 years ago

The circleCI check fails because it's using MongoDB 3.0 or before. Lookup which is used for pivots doesn't work before 3.2

vzsg commented 7 years ago

Don't let that break your flow :) EDIT: it seems that you are also using 3.4 features ($replaceRoot).

vzsg commented 7 years ago

There. Now it's green.

Joannis commented 7 years ago

@vzsg I think it's better to leave replaceRoot out for MongoDB 3.2 users and flatMap the cursor instead, what do you think?

Joannis commented 7 years ago

It's this simple. I think it's better :)

vzsg commented 7 years ago

I agree, and this is an elegant workaround. :+1: