search

vapor-community / mongo-driver

MongoDB driver for Fluent
28 stars 26 forks source link

Aggregates (min, max, sum, avg), Swift 4 support, Query filter bug fixes #48

Closed valeriomazzeo closed 7 years ago

valeriomazzeo commented 7 years ago

failing tests for aggregate min and max

valeriomazzeo commented 7 years ago

@Joannis I have fixed min and max, but there are some tests failing because the current structure is assuming that the query filters are always on the same entity.

Unfortunately, this is not always the case, so the whole code needs a little bit of refactoring. I'd like to discuss it with you, before continuing.

/cc @tanner0101

valeriomazzeo commented 7 years ago

@Joannis I have changed what you asked.

Regarding the whitespaces, I am definitely not familiar with the way you like it to be in the project, so I have only removed the one you pointed at.

About, the swift package file, I'd rather you to take care of it, because we may have different understanding about how it is supposed to work and which versions should mongo-driver supports at the same time.

If you recognise there isn't any change needed at a functional level, please go ahead and feel free to change whatever you need to make a release.