Is there a way to make this compatible with Vapor 4/SPM?

vapor-community / onesignal

13 stars 11 forks source link

Is there a way to make this compatible with Vapor 4/SPM? #6

Open geeksweep opened 4 years ago

geeksweep commented 4 years ago

Been talking with @anthonycastelli about this , going through Vapor 3 issues. Wondering if anyone can take on converting this to Vapor 4/SPM?

geeksweep commented 4 years ago

@anthonycastelli

charlymr commented 3 years ago

@geeksweep Hello if you are still interested, I removed all dependencies in my version, making it usable anywhere. https://github.com/charlymr/onesignal

0xTim commented 3 years ago

Just a heads up, URLSession is not advised for a server app - it doesn't play nice with futures or concurrency etc though is better than something that won't compile!

The canonical way would be to build this on top of AsyncHTTPClient and SwiftNIO if anyone wants to do the port.