initialization changes

[Prince2k3]

Changed the initializer to convenience and then created a new designated initializer. init(params: String ...) throws this will allow anyone with a special case to enter whatever arguments they want .

ex being

try self.init(params: "host", host, "port", port, "dbname", dbname, "user", user, "password", password, "{some new var}", "{value}")

[codecov-io]

Current coverage is 73.48% (diff: 90.00%)

Merging #18 into master will decrease coverage by 19.87%

@@             master        #18   diff @@
==========================================
  Files            11          7      -4   
  Lines          1748        298   -1450   
  Methods           0          0           
  Messages          0          0           
  Branches          0          0           
==========================================
- Hits           1632        219   -1413   
+ Misses          116         79     -37   
  Partials          0          0           

Powered by Codecov. Last update c694c8e...071e96d

[natebird]

This would address issue #15

[Prince2k3]

@sroebert made that change mentioned in the conversation

[sroebert]

When looking at the documentation (https://www.postgresql.org/docs/8.1/static/libpq.html), I think you can change two minor things.

• The parameters should be separated by spaces, which is a small addition to the joined call.
• ' and \ in the value should be escaped. This would be nice to do in the init instead of letting the user do this.

[tanner0101]

Just noticed you fixed the merge conflict after I manually added to #23. Sorry D:

[Prince2k3]

@sroebert

[anthonyroani]

Is this resolved ? I need to enable the SSL on my connection but I didn't find the changes you made... VaporPostgreSQL.Provider(host: "xxxxx", port: , dbname: "xxxx", user: "xxxx", password: "xxxx", "ssl???","enabled???")

[Prince2k3]

@anthonyroani I would look at this PR. https://github.com/vapor/postgresql/pull/23

Probably remake a case to get PR #23 back in rotation. (which I thought it was good enough)

[anthonyroani]

On 20 Dec 2016, at 16:39, Prince Ugwuh notifications@github.com wrote:

@anthonyroani https://github.com/anthonyroani I would look at this PR. #23 https://github.com/vapor/postgresql/pull/23 Probably remake a case to get PR #23 https://github.com/vapor/postgresql/pull/23 back in rotation. (which I thought it was good enough)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/vapor/postgresql/pull/18#issuecomment-268274944, or mute the thread https://github.com/notifications/unsubscribe-auth/APVl3a71zcM-5IMBWHazv0YA3tZGgBS-ks5rJ_aXgaJpZM4KfUHp.

[Prince2k3]

It has to go through testing first…once it does I’ll take to folks about merging and releasing it. not sure if they had plans for the branch or not. if all is good I’ll make a release and post it

On Dec 20, 2016, at 9:56 AM, Anthony Roani notifications@github.com wrote:

I didn't understand very well what should I do ? Have I to pull the cleanup branch to get changes ?

On 20 Dec 2016, at 16:39, Prince Ugwuh notifications@github.com wrote:

@anthonyroani https://github.com/anthonyroani I would look at this PR. #23 https://github.com/vapor/postgresql/pull/23 Probably remake a case to get PR #23 https://github.com/vapor/postgresql/pull/23 back in rotation. (which I thought it was good enough)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/vapor/postgresql/pull/18#issuecomment-268274944, or mute the thread https://github.com/notifications/unsubscribe-auth/APVl3a71zcM-5IMBWHazv0YA3tZGgBS-ks5rJ_aXgaJpZM4KfUHp.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/vapor/postgresql/pull/18#issuecomment-268279749, or mute the thread https://github.com/notifications/unsubscribe-auth/ACrOJRSSsdkNeEEQAZbGXG_FoR6JlbUSks5rJ_qpgaJpZM4KfUHp.

[anthonyroani]

Ok thank you. Hope this will be released soon !

Le 20 déc. 2016 à 17:31, Prince Ugwuh notifications@github.com a écrit :

It has to go through testing first…once it does I’ll take to folks about merging and releasing it. not sure if they had plans for the branch or not. if all is good I’ll make a release and post it

On Dec 20, 2016, at 9:56 AM, Anthony Roani notifications@github.com wrote:

I didn't understand very well what should I do ? Have I to pull the cleanup branch to get changes ?

On 20 Dec 2016, at 16:39, Prince Ugwuh notifications@github.com wrote:

@anthonyroani https://github.com/anthonyroani I would look at this PR. #23 https://github.com/vapor/postgresql/pull/23 Probably remake a case to get PR #23 https://github.com/vapor/postgresql/pull/23 back in rotation. (which I thought it was good enough)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/vapor/postgresql/pull/18#issuecomment-268274944, or mute the thread https://github.com/notifications/unsubscribe-auth/APVl3a71zcM-5IMBWHazv0YA3tZGgBS-ks5rJ_aXgaJpZM4KfUHp.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/vapor/postgresql/pull/18#issuecomment-268279749, or mute the thread https://github.com/notifications/unsubscribe-auth/ACrOJRSSsdkNeEEQAZbGXG_FoR6JlbUSks5rJ_qpgaJpZM4KfUHp.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/vapor/postgresql/pull/18#issuecomment-268289466, or mute the thread https://github.com/notifications/unsubscribe-auth/APVl3U0ZWDtTj8GI2P1I5OWrgnVgPt1Wks5rKALYgaJpZM4KfUHp.