Closed natebird closed 7 years ago
I can't seem to get CircleCI to run on PR for this project? And Travis fails on the macOS build even though it works fine locally.
Update: I fixed CircleCI with a project configuration change.
@natebird have you tried changing the Xcode version in your travis.yml file to xcode8.3
as per https://docs.travis-ci.com/user/osx-ci-environment/#OS-X-Version? I'm wondering if it's trying to build it with a Swift 3.0 toolchain
So for some reason it is still running on Swift 3.0 https://travis-ci.org/vapor/postgresql/jobs/218840790#L65, which is confusing!
Ah you're ca16f31 commit has removed the xcode8.3
OS X image specifier?
(You can do git commit --allow-empty
to kick build systems with an empty commit)
@0xTim yeah, It didn't build postgres with the xcode8.3 option. Trying again.
@0xTim yep. same thing again. Postgres isn't starting. https://travis-ci.org/vapor/postgresql/jobs/218843500
Hmm that's frustrating!
Current status: Kicking Travis until it does what I want.
Merging #35 into master will decrease coverage by
0.42%
. The diff coverage is90.76%
.
@@ Coverage Diff @@
## master #35 +/- ##
=========================================
- Coverage 92.63% 92.2% -0.43%
=========================================
Files 12 12
Lines 1807 1810 +3
=========================================
- Hits 1674 1669 -5
- Misses 133 141 +8
Impacted Files | Coverage Δ | |
---|---|---|
Sources/PostgreSQL/Status.swift | 25% <ø> (ø) |
:arrow_up: |
Sources/PostgreSQL/Node+Oid.swift | 98.2% <ø> (ø) |
:arrow_up: |
Sources/PostgreSQL/Result.swift | 91.66% <ø> (-8.34%) |
:arrow_down: |
Sources/PostgreSQL/Database.swift | 81.81% <ø> (ø) |
:arrow_up: |
Sources/PostgreSQL/ConnectionInfo.swift | 33.33% <ø> (ø) |
:arrow_up: |
Tests/PostgreSQLTests/PostgreSQLTests.swift | 96.03% <100%> (+0.53%) |
:arrow_up: |
Tests/PostgreSQLTests/ArrayTests.swift | 100% <100%> (+1.29%) |
:arrow_up: |
Sources/PostgreSQL/Node+Binding.swift | 80.19% <42.85%> (-2.96%) |
:arrow_down: |
Sources/PostgreSQL/Connection.swift | 79% <88.23%> (ø) |
:arrow_up: |
Tests/PostgreSQLTests/Utilities.swift | 53.57% <0%> (-10.72%) |
:arrow_down: |
... and 1 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update e8e549c...754493b. Read the comment docs.
Updates to comply with beta dependencies.