Closed natebird closed 7 years ago
Merging #36 into master will decrease coverage by
2.77%
. The diff coverage is71.65%
.
@@ Coverage Diff @@
## master #36 +/- ##
==========================================
- Coverage 92.65% 89.87% -2.78%
==========================================
Files 14 17 +3
Lines 1879 1966 +87
==========================================
+ Hits 1741 1767 +26
- Misses 138 199 +61
Impacted Files | Coverage Δ | |
---|---|---|
Tests/PostgreSQLTests/MiscTests.swift | 100% <100%> (ø) |
|
Tests/PostgreSQLTests/PostgreSQLTests.swift | 96.44% <100%> (+0.21%) |
:arrow_up: |
Sources/PostgreSQL/Notification.swift | 100% <100%> (ø) |
:arrow_up: |
Sources/PostgreSQL/Context.swift | 100% <100%> (ø) |
|
Sources/PostgreSQL/ConnectionInfo.swift | 66.66% <100%> (ø) |
:arrow_up: |
Sources/PostgreSQL/Error.swift | 5.26% <5.26%> (ø) |
|
Sources/PostgreSQL/Connection.swift | 81.37% <64%> (-3.9%) |
:arrow_down: |
Tests/PostgreSQLTests/Utilities.swift | 53.57% <85.71%> (ø) |
:arrow_up: |
Sources/PostgreSQL/Database.swift | 84.61% <87.09%> (ø) |
:arrow_up: |
Tests/PostgreSQLTests/ConnectionTests.swift | 87.5% <90.69%> (+7.5%) |
:arrow_up: |
... and 3 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 9b11b11...8569400. Read the comment docs.
Most of changes below are to make things consistent with the Vapor MySQL counterpart and to help support features in the PostgreSQL Driver.
Changes:
host
tohostname
. This allows for supporting master and read replica in PostgreSQL Driver.connected
boolean toisConnected
.connection
pointer tocConnection
.error
var tolastError
.New:
isPostgreSQL
var.