search

vapor-community / postgresql

Robust PostgreSQL interface for Swift
MIT License
131 stars 33 forks source link

Numeric value parsing fixes #48

Closed vzsg closed 7 years ago

vzsg commented 7 years ago

This PR is currently a reproduction for #47.

codecov[bot] commented 7 years ago

Codecov Report

Merging #48 into master will increase coverage by 0.12%. The diff coverage is 86.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
+ Coverage   80.25%   80.37%   +0.12%     
==========================================
  Files          10       10              
  Lines        1028     1106      +78     
==========================================
+ Hits          825      889      +64     
- Misses        203      217      +14
Impacted Files Coverage Δ
Sources/PostgreSQL/Bind/BinaryUtils.swift 94.44% <86.88%> (-3.67%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e8b5c62...408600c. Read the comment docs.

vzsg commented 7 years ago

Why the test doesn't fail in CI is kinda beyond me...

vzsg commented 7 years ago

Thank you again!

natebird commented 7 years ago

@sroebert Thanks!