search

vapor-community / postgresql

Robust PostgreSQL interface for Swift
MIT License
131 stars 33 forks source link

Update for Swift 5. #79

Closed ken-broadsheet closed 4 years ago

ken-broadsheet commented 4 years ago

Updates source and Package.swift for Swift 5 compatibility.

0xTim commented 4 years ago

To avoid breaking any old existing clients, it's probably best to have this as a Package@swift-5.swift manifest in addition to the existing one

ken-broadsheet commented 4 years ago

Done – this may break Swift 3 anyway due to the code changes, so it'd probably be best to release as a new major version.

0xTim commented 4 years ago

Ah yeah - what are you using this project for by the way? I'm not sure whether a release will happen as this is a Vapor 2 package that is long past it's EOL

ken-broadsheet commented 4 years ago

I'm using it for a project with a Google CloudSQL database. I chose this over Swift-Kuery because it doesn't do stupid things with async dispatch.

I just noticed https://github.com/PerfectlySoft/Perfect-PostgreSQL, which might also work for me.

0xTim commented 4 years ago

Yeah the whole server-side Swift industry is moving to libraries based on NIO - this is the one that's been pitched to the SSWG

0xTim commented 4 years ago

PS, we can make the changes non-breaking by using compiler directives to switch on the version of Swift

ken-broadsheet commented 4 years ago

Done.

0xTim commented 4 years ago

This is released as 2.2.0

ken-broadsheet commented 4 years ago

Thank you!

On Mon, May 18, 2020 at 8:20 AM Tim Condon notifications@github.com wrote:

This is released as 2.2.0 https://github.com/vapor-community/postgresql/releases/tag/2.2.0

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/vapor-community/postgresql/pull/79#issuecomment-630253512, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOHH7XYNH7JUH7SSHG62SZLRSFG2JANCNFSM4MZGISSA .