search

vapor-community / sendgrid-kit

📧 A Swift on Server SDK for the SendGrid API
https://swiftpackageindex.com/vapor-community/sendgrid-kit
MIT License
10 stars 14 forks source link

Make the Personalization’s dynamicTemplateData generic #17

Closed tonyarnold closed 3 weeks ago

tonyarnold commented 1 year ago

This should allow support for nested Codable structures, and better type support when encoded to JSON (everything needed to be a string, so things like numbers, nil and booleans were not being encoded properly.

It does, sadly, make the declaration of Personalization instances a bit messier. I'm open to approaches here.

Fixes #7

tonyarnold commented 1 year ago

@Andrewangeta what are the chances of this PR making it into a release (even a tagged beta) at some point soon? Did you need to see any changes to the code?

Andrewangeta commented 1 year ago

@tonyarnold Hey! Sorry for the delay. Would you be ok/comfortable taking over and maintaining this repo? I have a TON on my plate constantly and don't want to hinder growth and development of the ecosystem because I'm too busy. I actually don't even use sendgrid myself so I'd much rather someone else with more invested take over and be a contributor and shape the evolution of the package overtime. Just LMK and you can take the reigns and do what's bets for this library :)

tonyarnold commented 1 year ago

@Andrewangeta I'd be happy to help in whatever way makes sense. I'm happy to look after the library for the time being, and if you find yourself with time/inclination in future just let me know.

tonyarnold commented 1 year ago

@Andrewangeta are there any expectations, rules, etc around maintaining this package? (and, I assume the parent https://github.com/vapor-community/sendgrid package).

If I want to make a release, are there docs on how to go about that?

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (c00b291) to head (3547866). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #17 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 9 9 Lines 104 137 +33 ========================================= + Hits 104 137 +33 ``` | [Files with missing lines](https://app.codecov.io/gh/vapor-community/sendgrid-kit/pull/17?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor-community) | Coverage Δ | | |---|---|---| | [Sources/SendGridKit/Models/MailSettings.swift](https://app.codecov.io/gh/vapor-community/sendgrid-kit/pull/17?src=pr&el=tree&filepath=Sources%2FSendGridKit%2FModels%2FMailSettings.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor-community#diff-U291cmNlcy9TZW5kR3JpZEtpdC9Nb2RlbHMvTWFpbFNldHRpbmdzLnN3aWZ0) | `100.00% <100.00%> (ø)` | | | [Sources/SendGridKit/Models/Personalization.swift](https://app.codecov.io/gh/vapor-community/sendgrid-kit/pull/17?src=pr&el=tree&filepath=Sources%2FSendGridKit%2FModels%2FPersonalization.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor-community#diff-U291cmNlcy9TZW5kR3JpZEtpdC9Nb2RlbHMvUGVyc29uYWxpemF0aW9uLnN3aWZ0) | `100.00% <100.00%> (ø)` | | | [Sources/SendGridKit/Models/SendGridEmail.swift](https://app.codecov.io/gh/vapor-community/sendgrid-kit/pull/17?src=pr&el=tree&filepath=Sources%2FSendGridKit%2FModels%2FSendGridEmail.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor-community#diff-U291cmNlcy9TZW5kR3JpZEtpdC9Nb2RlbHMvU2VuZEdyaWRFbWFpbC5zd2lmdA==) | `100.00% <100.00%> (ø)` | | | [Sources/SendGridKit/Models/TrackingSettings.swift](https://app.codecov.io/gh/vapor-community/sendgrid-kit/pull/17?src=pr&el=tree&filepath=Sources%2FSendGridKit%2FModels%2FTrackingSettings.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor-community#diff-U291cmNlcy9TZW5kR3JpZEtpdC9Nb2RlbHMvVHJhY2tpbmdTZXR0aW5ncy5zd2lmdA==) | `100.00% <100.00%> (ø)` | | | [Sources/SendGridKit/SendGridClient.swift](https://app.codecov.io/gh/vapor-community/sendgrid-kit/pull/17?src=pr&el=tree&filepath=Sources%2FSendGridKit%2FSendGridClient.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor-community#diff-U291cmNlcy9TZW5kR3JpZEtpdC9TZW5kR3JpZENsaWVudC5zd2lmdA==) | `100.00% <100.00%> (ø)` | |