Access control on setOption and resolve

vapor-community / sockets

🔌 Non-blocking TCP socket layer, with event-driven server and client.

MIT License

575 stars 54 forks source link

Access control on setOption and resolve #125

Closed kydos closed 6 years ago

kydos commented 7 years ago

Hello,

I wonder why the operations listed below have internal access control:

InternetAddress.resolve
Descriptor.(setOption | getOption | setBoolOption | getBoolOption)

The get/set Option operations are handy to change manipulate the socket options, for instance to join/leave a multicast group as well as to deal with the ADDR/PORT reuse.

Likewise the resolve operation on the InternetAddress is kind of essential to send a datagram over an unconnected UDP socket.

Ciao, Kydos

tanner0101 commented 7 years ago

I'll look into publicizing those methods for 2.0.

kydos commented 7 years ago

Great thanks!

tanner0101 commented 6 years ago

We've moved to a different setup now in Vapor 3. This should no longer be a problem.