search

vapor-community / sockets

🔌 Non-blocking TCP socket layer, with event-driven server and client.
MIT License
575 stars 54 forks source link

Remove `periodSeparatedString()` #17

Closed stephencelis closed 8 years ago

stephencelis commented 8 years ago

The performance benefits of raw enumeration are slight and the standard library implementation could surpass it at any time. We can favor less code (and fewer required tests) instead!

czechboy0 commented 8 years ago

Can you please keep the tests? And maybe even keep the function periodSeparatedString(), just implement it as you suggested.

stephencelis commented 8 years ago

I'll have to leave that to you. I'm sick as a dog right now but was browsing and wanted to help simplify. Good luck!

czechboy0 commented 8 years ago

Sounds good, thanks :)