vapor-community / sockets

🔌 Non-blocking TCP socket layer, with event-driven server and client.
MIT License
575 stars 54 forks source link

Carthage #19

Closed TofPlay closed 8 years ago

TofPlay commented 8 years ago

Hi, It's will be great to add Carthage support

Take a look at these articles:

czechboy0 commented 8 years ago

Hi @TofPlay,

do you have a project where you'd use that? Currently Socks is using the latest Swift 3.0 snapshot and it's going to for the foreseeable future. I was considering adding both CocoaPods & Carthage support eventually, once Swift 3 is out and Socks' API stabilizes.

I could look at it later, but if you need it sooner, feel free to send a PR. I wouldn't see a reason to not merge it. :blush:

czechboy0 commented 8 years ago

@TofPlay I'll close this for now, since there isn't a next step from our side. As I mentioned above, feel free to send a PR with Carthage support, but we won't spend time on supporting CocoaPods/Carthage just yet as this is a server-facing package rather than iOS etc.

JetForMe commented 5 years ago

@TofPlay I'll close this for now, since there isn't a next step from our side. As I mentioned above, feel free to send a PR with Carthage support, but we won't spend time on supporting CocoaPods/Carthage just yet as this is a server-facing package rather than iOS etc.

Just FYI, if one needs to embed a web server in a macOS or iOS app (I have had to more than once), Carthage support would be ideal.

0xTim commented 5 years ago

Correct me if I'm wrong but I don't think Carthage support is something that will ever happen, due to the way SPM and Carthage just don't play nice. Carthage requires a projects scheme to be shared. SPM doesn't have a project file so making them work together will likely cause some issues.

Don't get me wrong, I think full Vapor support on iOS is something that should be worked on, but it's most likely to come via SPM (especially now that NIO supports iOS) or failing that Cocoapods (which brings its own problems).