Closed loganwright closed 8 years ago
Looks good to me! I suggest to merge https://github.com/vapor/socks/pull/87 into the same tag to get proper error messages if some users report problems.
@andreasley sounds good, I'll update that branch and give travis a moment to run w/ my changes.
@andreasley @tannernelson I think the issue was something to do w/ float tolerances, can the two of you confirm that this is ready to merge 👍