Various improvements

[andreasley]

Improved performance

Previously, all bytes received were passed trough an map operation that is not required, since the bytes are already UInt8. This change improves performance for large transfers considerably.

Improves https://github.com/vapor/vapor/issues/734

Improved cleanup and safety

• TCPInternetSocket and UDPInternetSocket now close their descriptors on deinit
• Additional calls to close() don't try to close the file descriptor anymore
• Attempts to use a closed TCPInternetSocket or UDPInternetSocket now throw to prevent using a descriptor that may already be used otherwise

Improved testing

• WatchingTests are now run under Linux, too
• WatchingTests should not fail anymore
• Added tests for releasing and using closed sockets

[tanner0101]

Great find. Tests failed on macOS, though. Re-rerunning to make sure it wasn't a network issue.

[andreasley]

I've had tests on CI failing for no reason in the last few weeks – tests that succeeded every time when run locally. I think we're pushing the boundaries of Travis with all this TCP stuff. :) In general, I think it's best to create sockets in tests on any available port instead of a specific one.

[tanner0101]

Yeah, I'm pretty sure it's their issue. The tests were written by the original author of this package so hopefully they don't need to be reworked just for Travis.

[loganwright]

I'm not sure why these lines are failing on osx:

https://github.com/vapor/socks/blob/ea09c395312e772ae9ad9a8834c61411fcaec10a/Tests/SocksCoreTests/OptionsTests.swift#L29

https://github.com/vapor/socks/blob/ea09c395312e772ae9ad9a8834c61411fcaec10a/Tests/SocksCoreTests/OptionsTests.swift#L33

[codecov-io]

Current coverage is 64.93% (diff: 75.63%)

No coverage report found for master at bd9af15.

Powered by Codecov. Last update bd9af15...bcdcabe