vapor-community / sqlite-provider

SQLite3 provider for Vapor
MIT License
10 stars 8 forks source link

Update to Vapor 0.18, Fluent 0.11 and Swift GM #4

Closed adriencanterot closed 8 years ago

adriencanterot commented 8 years ago

PR does not build

Hi everyone, I just updated the sqlite-provider package, it works with Vapor 0.17. It does not build but since I made PRs on vapor/sqlite, vapor/sqlite-driver and vapor/sqlite-provider to keep them up tp date, updating the version of each package should make it work with Vapor.

New

For the sqlite.json file I imagined a simple structure as follows :

{
     "path": "Database/main.sqlite"
} 

Thank you for reviewing this proposal

tanner0101 commented 8 years ago

This looks good. So we need to merge the PRs to sqlite first then sqlite-driver?

adriencanterot commented 8 years ago

That's right, once the sqlite PR is tagged, sqlite-driver should build, then tagged, then this one should build as well. I might need to have a last look at sqlite-driver though, I'll comment again when ready.

tanner0101 commented 8 years ago

SQLite 0.3 is tagged: https://github.com/vapor/sqlite/releases/tag/0.3.0

adriencanterot commented 8 years ago

Hi @tannernelson , this one is ready to be merged and tagged as well. Ready for GM and Vapor 0.18.

Tanner commented 8 years ago

Just to let you know, you're pinging me, not @tannernelson.

adriencanterot commented 8 years ago

Oh sorry, I thought it worked like Facebook or something, my bad :/