search

vapor-ware / kubetest

Kubernetes integration testing in Python via pytest
https://kubetest.readthedocs.io/en/latest/
GNU General Public License v3.0
206 stars 57 forks source link

Read KUBECONFIG environment variable globally instead of only in kube fixture #206

Closed joshrivers closed 3 years ago

joshrivers commented 3 years ago

This change should resolve https://github.com/vapor-ware/kubetest/issues/205 by referencing the KUBECONFIG environment variable whenever kubeconfig is injected from the fixture, rather than only reading it when kubeconfig is None in the kube fixture.

I tested that this resolves my local issue, and the unit tests all pass after making the change.

joshrivers commented 3 years ago

Moved environment variable to be supplied as the default value in the CLI options parsers, since supplying it later caused an issue like https://github.com/vapor-ware/kubetest/issues/154

edaniszewski commented 3 years ago

This is awesome, thanks so much for the contribution! I'll try to get a new release cut with this in it soon.