encrypt message incorrctly specifies ⌘+D as EOF

vapor-ware / sctl

SCTL is not End2End encryption, instead SCTL is more of an envelope, in which you store secrets until they are needed, and those secrets should only remain available in plain text while the operation that needs them is active.

GNU General Public License v3.0

8 stars 2 forks source link

encrypt message incorrctly specifies ⌘+D as EOF #37

Closed edaniszewski closed 5 years ago

edaniszewski commented 5 years ago

⌘+D (command-D) in terminal is the shortcut to split the pane. To issue an EOF, it should be ^D (control-D)

lazypower commented 5 years ago

@marcoceppi didn't we test this? I'm pretty sure this depends on which terminal emulator you're using...

marcoceppi commented 5 years ago

@edaniszewski which terminal are you using?

edaniszewski commented 5 years ago

@marcoceppi just the regular ol' bash terminal that ships with macOS

edaniszewski commented 5 years ago

Split Pane used to be bound to ⌘D, but I rebound it to use here. Once unbound, it didn't seem to do anything to send EOF/terminate input. ^D did do things.. but I think I ran into another issue at that point (#36 ) so I can't say for sure that ^D is the answer.

lazypower commented 5 years ago

@KylerBurke is an OSX user - can you confirm/deny that you use ctrl d during data input to end the read loop sequence?

KylerBurke commented 5 years ago

@lazypower yes can confirm. ⌘+D splits the pane. I know this and avoid the combination. I'd been pressing ctrl+D to EOF for sctl encrypt commands without realizing the message was incorrect. If I do exactly as sctl says, I split the pane. This should be ctrl+D

marcoceppi commented 5 years ago

Can you include what version of OSX you're for those in this thread?

marcoceppi commented 5 years ago

I also just checked on my Mojave and Catalina mac. Cmd+D is split window, I tested this so many times I have no idea how it got mixed up

lazypower commented 5 years ago

Its no worries! :) We're human after all.

Thank you all for helping track this down and verify