update label used to identify synse plugins

vapor-ware / synse-charts

Helm charts for deploying the Synse project ⛵

https://charts.vapor.io

GNU General Public License v3.0

1 stars 0 forks source link

update label used to identify synse plugins #89

Closed edaniszewski closed 3 years ago

edaniszewski commented 4 years ago

Currently the label synse-component: plugin is used to identify synse plugins. This is used by synse-server, for example, to find/connect to plugins at runtime.

Given that best practices are to namespace labels (e.g. app.kubernetes.io/name, vapor.io/monitor -- see also: https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/#labels), would it make sense to update this plugin label to something like:

vapor.io/synse: plugin

lazypower commented 3 years ago

Yeah! I'm all for this.

edaniszewski commented 3 years ago

closing -- this has been implemented in the latest updates for charts. we can also set any other labels we may want to use explicitly at config-time under the service.labels config option.