bugfix: reset client on read failure

vapor-ware / synse-modbus-ip-plugin

Modbus over TCP/IP plugin for Synse

GNU General Public License v3.0

2 stars 3 forks source link

bugfix: reset client on read failure #45

Closed edaniszewski closed 4 years ago

edaniszewski commented 4 years ago

This PR:

should fix a bug where failure to read because of client reset/eof/connection close causes the manager client to become stale and unusable. it does so by creating a new client whenever there is a read failure.

edaniszewski commented 4 years ago

Sorry, missed your comment/approve earlier. I think on monday it would be a good test for us to restart the egauge plugins that are currently running, verify they get readings, then reboot the egauges if possible to do manually. If we see the same issue in the logs, that would be great as it means its reproducible, then we can upgrade the images to include these changes and try the same thing and check to see if these changes actually help with the issue.