vapor-ware / synse-sdk

SDK for Synse Plugins in Go
https://synse.readthedocs.io/en/latest/sdk/intro/
GNU General Public License v3.0
3 stars 4 forks source link

auto_enumerate example has an error #125

Closed MatthewHink closed 6 years ago

MatthewHink commented 6 years ago

It may be benign (?) but looks bad.

Line is: ERRO[0000] devicesFromConfig. error from ParseDeviceConfig stat ./config/device: no such file or directory

Repro:

[mhink@ion ~/go/src/github.com/vapor-ware/synse-sdk (master)]$ git branch | grep master
* master
[mhink@ion ~/go/src/github.com/vapor-ware/synse-sdk (master)]$ cd examples/auto_enumerate/
[mhink@ion ~/go/src/github.com/vapor-ware/synse-sdk/examples/auto_enumerate (master)]$ rm plugin
[mhink@ion ~/go/src/github.com/vapor-ware/synse-sdk/examples/auto_enumerate (master)]$ git log -n 1
commit 2195d248cabe6f21880a414cd552f1c689922b64 (HEAD -> master, origin/master, origin/HEAD)
Merge: cc41c11 b8b135b
Author: MatthewHink <matthew_hink@yahoo.com>
Date:   Wed Feb 14 15:42:14 2018 -0800

    Merge pull request #121 from vapor-ware/mhink-move-file

    sdk/manager.go -> sdk/data_manager.go
[mhink@ion ~/go/src/github.com/vapor-ware/synse-sdk/examples/auto_enumerate (master)]$ make build
[mhink@ion ~/go/src/github.com/vapor-ware/synse-sdk/examples/auto_enumerate (master)]$ ./plugin
DEBU[0000] devicesFromConfig start
DEBU[0000] ParseDeviceConfig start
DEBU[0000] ParseDeviceConfig 2
ERRO[0000] devicesFromConfig. error from ParseDeviceConfig stat ./config/device: no such file or directory
INFO[0000] Plugin Info:
INFO[0000]  Name:        auto-enum-plugin
INFO[0000]  Version:     1.0
INFO[0000]  SDK Version: 0.4.0
INFO[0000]  Git Commit:  2195d24
INFO[0000]  Git Tag:     0.4.0-19-g2195d24
INFO[0000]  Go Version:  go1.9.3
INFO[0000]  Build Date:  2018-02-15T04:53:18
INFO[0000]  OS:          darwin
INFO[0000]  Arch:        amd64
DEBU[0000] Plugin Config:
DEBU[0000]  &config.PluginConfig{Name:"auto-enum-plugin", Version:"1", Debug:true, Settings:config.Settings{LoopDelay:500, Read:config.ReadSettings{BufferSize:150}, Write:config.WriteSettings{BufferSize:150, PerLoop:4}, Transaction:config.TransactionSettings{TTL:600}}, Network:config.NetworkSettings{Type:"unix", Address:"auto-enum-plugin.sock"}, AutoEnumerate:[]map[string]interface {}{map[string]interface {}{"base":10}, map[string]interface {}{"base":13}}, Context:map[string]interface {}{}}
INFO[0000] Registered Devices:
INFO[0000] --------------------------------
INFO[0000] starting read-write poller
INFO[0000] starting data updater
INFO[0000] listening on network unix with address /tmp/synse/procs/auto-enum-plugin.sock
INFO[0000] serving
^C
[mhink@ion ~/go/src/github.com/vapor-ware/synse-sdk/examples/auto_enumerate (master)]$
MatthewHink commented 6 years ago

For bonus points, try commenting out this linter disable if this makes it into master.

handlers, err := NewHandlers(ProtocolIdentifier, EnumerateDevices) // nolint: varcheck, maligned, structcheck, unconvert, megacheck, interfacer

^ Above is not an issue.

edaniszewski commented 6 years ago

closing -- this issue is part of the bigger issue of config handling/validation. these issues are addressed and fixed in version 1.0