search

vapor-ware / synse-sdk

SDK for Synse Plugins in Go
https://synse.readthedocs.io/en/latest/sdk/intro/
GNU General Public License v3.0
3 stars 4 forks source link

CI "build examples" stage doesn't fail if example build fails #130

Closed edaniszewski closed 6 years ago

edaniszewski commented 6 years ago

in a PR where the build should have failed, it didnt. looking at the CI logs, I see that the error is there

#!/bin/bash -eo pipefail
make examples

examples/auto_enumerate/
github.com/vapor-ware/synse-sdk/vendor/github.com/rs/xid
github.com/vapor-ware/synse-sdk/vendor/github.com/patrickmn/go-cache
github.com/vapor-ware/synse-sdk/vendor/golang.org/x/sys/unix
github.com/vapor-ware/synse-sdk/vendor/github.com/hashicorp/hcl/hcl/strconv
github.com/vapor-ware/synse-sdk/vendor/github.com/pelletier/go-toml
github.com/vapor-ware/synse-sdk/vendor/github.com/spf13/afero/mem
github.com/vapor-ware/synse-sdk/vendor/github.com/mitchellh/mapstructure
github.com/vapor-ware/synse-sdk/vendor/github.com/spf13/cast
github.com/vapor-ware/synse-sdk/vendor/github.com/spf13/jwalterweatherman
github.com/vapor-ware/synse-sdk/vendor/golang.org/x/text/transform
github.com/vapor-ware/synse-sdk/vendor/gopkg.in/yaml.v2
github.com/vapor-ware/synse-sdk/vendor/golang.org/x/net/context
github.com/vapor-ware/synse-sdk/vendor/golang.org/x/net/http2/hpack
github.com/vapor-ware/synse-sdk/vendor/github.com/golang/protobuf/proto
github.com/vapor-ware/synse-sdk/vendor/golang.org/x/text/unicode/bidi
github.com/vapor-ware/synse-sdk/vendor/golang.org/x/net/internal/timeseries
github.com/vapor-ware/synse-sdk/vendor/google.golang.org/grpc/grpclog
github.com/vapor-ware/synse-sdk/vendor/google.golang.org/grpc/resolver
github.com/vapor-ware/synse-sdk/vendor/google.golang.org/grpc/codes
github.com/vapor-ware/synse-sdk/vendor/github.com/magiconair/properties
github.com/vapor-ware/synse-sdk/vendor/github.com/spf13/pflag
github.com/vapor-ware/synse-sdk/vendor/google.golang.org/grpc/encoding
github.com/vapor-ware/synse-sdk/vendor/google.golang.org/grpc/internal
github.com/vapor-ware/synse-sdk/vendor/google.golang.org/grpc/keepalive
github.com/vapor-ware/synse-sdk/vendor/github.com/hashicorp/hcl/hcl/token
github.com/vapor-ware/synse-sdk/vendor/google.golang.org/grpc/resolver/passthrough
github.com/vapor-ware/synse-sdk/vendor/google.golang.org/grpc/credentials
github.com/vapor-ware/synse-sdk/vendor/google.golang.org/grpc/metadata
github.com/vapor-ware/synse-sdk/vendor/google.golang.org/grpc/stats
github.com/vapor-ware/synse-sdk/vendor/google.golang.org/grpc/tap
github.com/vapor-ware/synse-sdk/vendor/github.com/hashicorp/hcl/hcl/ast
github.com/vapor-ware/synse-sdk/vendor/github.com/hashicorp/hcl/hcl/scanner
github.com/vapor-ware/synse-sdk/vendor/github.com/hashicorp/hcl/json/token
github.com/vapor-ware/synse-sdk/vendor/golang.org/x/text/unicode/norm
github.com/vapor-ware/synse-sdk/vendor/google.golang.org/grpc/connectivity
github.com/vapor-ware/synse-sdk/vendor/google.golang.org/grpc/naming
github.com/vapor-ware/synse-sdk/vendor/google.golang.org/grpc/resolver/dns
github.com/vapor-ware/synse-sdk/vendor/golang.org/x/net/trace
github.com/vapor-ware/synse-sdk/vendor/github.com/hashicorp/hcl/json/scanner
github.com/vapor-ware/synse-sdk/vendor/github.com/hashicorp/hcl/hcl/parser
github.com/vapor-ware/synse-sdk/vendor/google.golang.org/grpc/balancer
github.com/vapor-ware/synse-sdk/vendor/google.golang.org/grpc/peer
github.com/vapor-ware/synse-sdk/vendor/github.com/hashicorp/hcl/json/parser
github.com/vapor-ware/synse-sdk/vendor/golang.org/x/text/secure/bidirule
github.com/vapor-ware/synse-sdk/vendor/google.golang.org/grpc/balancer/base
github.com/vapor-ware/synse-sdk/vendor/github.com/hashicorp/hcl
github.com/vapor-ware/synse-sdk/vendor/google.golang.org/grpc/balancer/roundrobin
github.com/vapor-ware/synse-sdk/vendor/github.com/fsnotify/fsnotify
github.com/vapor-ware/synse-sdk/vendor/golang.org/x/crypto/ssh/terminal
github.com/vapor-ware/synse-sdk/vendor/github.com/spf13/afero
github.com/vapor-ware/synse-sdk/vendor/golang.org/x/net/idna
github.com/vapor-ware/synse-sdk/vendor/github.com/Sirupsen/logrus
github.com/vapor-ware/synse-sdk/vendor/golang.org/x/net/lex/httplex
github.com/vapor-ware/synse-sdk/vendor/google.golang.org/grpc/grpclb/grpc_lb_v1/messages
github.com/vapor-ware/synse-sdk/vendor/github.com/golang/protobuf/ptypes/any
github.com/vapor-ware/synse-sdk/vendor/github.com/golang/protobuf/ptypes/duration
github.com/vapor-ware/synse-sdk/vendor/github.com/golang/protobuf/ptypes/timestamp
github.com/vapor-ware/synse-sdk/vendor/golang.org/x/net/http2
github.com/vapor-ware/synse-sdk/vendor/google.golang.org/genproto/googleapis/rpc/status
github.com/vapor-ware/synse-sdk/vendor/github.com/golang/protobuf/ptypes
github.com/vapor-ware/synse-sdk/sdk/logger
github.com/vapor-ware/synse-sdk/vendor/google.golang.org/grpc/status
github.com/vapor-ware/synse-sdk/vendor/github.com/spf13/viper
github.com/vapor-ware/synse-sdk/vendor/google.golang.org/grpc/transport
github.com/vapor-ware/synse-sdk/vendor/google.golang.org/grpc
github.com/vapor-ware/synse-sdk/vendor/github.com/vapor-ware/synse-server-grpc/go
github.com/vapor-ware/synse-sdk/sdk/config
github.com/vapor-ware/synse-sdk/sdk
github.com/vapor-ware/synse-sdk/examples/auto_enumerate
# github.com/vapor-ware/synse-sdk/examples/auto_enumerate
./plugin.go:106: undefined: NewHandlers

but after this, it kept going on and building the other examples, not erroring out.

MatthewHink commented 6 years ago

See https://github.com/vapor-ware/synse-sdk/pull/134

MatthewHink commented 6 years ago

Fixed: https://github.com/vapor-ware/synse-sdk/commit/dc45357a56dcfbd624b700d1f7e1327a9d9fc37d