vapor-ware / synse-sdk

SDK for Synse Plugins in Go
https://synse.readthedocs.io/en/latest/sdk/intro/
GNU General Public License v3.0
3 stars 4 forks source link

panic possible on sending from closed channel during high-volume readstream #482

Open edaniszewski opened 3 years ago

edaniszewski commented 3 years ago

This was captured in the backgrorund, so there isn't much context around what exactly was running at the time, the throughput, etc, but looks like when there was A LOT of data streaming through, this happened once:

time="2021-01-11T01:15:28.596Z" level=info msg="closing read stream" id=1bc95670-c4a3-4b8a-94fc-28225fa67782
panic: send on closed channel

goroutine 425 [running]:
github.com/vapor-ware/synse-sdk/sdk.(*ReadStream).listen(0xc000618880)
    /go/pkg/mod/github.com/vapor-ware/synse-sdk@v0.1.0-alpha.0.20210110152329-2d8d42c478e7/sdk/stream.go:53 +0x4ba
created by github.com/vapor-ware/synse-sdk/sdk.(*server).ReadStream
    /go/pkg/mod/github.com/vapor-ware/synse-sdk@v0.1.0-alpha.0.20210110152329-2d8d42c478e7/sdk/server.go:530 +0xa09

will need additional investigation and RCA